-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
retrieval: Direct piecereader #6128
Conversation
9cb468b
to
911b558
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing seems very wrong, and I think I understand what it does. May even work.
When we tried to run this with our miner we got the following error when doing a retrieval:
|
^ likely caused by not setting the seal proof type in the http handler / remote store on either the worker or miner node |
@magik6k Thanks for that pointer. I'll grok this PR, factor in your suggestion and take this work to completion as we really need it to fix data retrievals. Btw, do you have any pointers to existing integration tests that we can use as reference to write integration tests for this feature ? |
Api tests which do retrieval (like this one) should be exercising most of the now code here (I'd run them with coverage to see if that's actually the case). Testing the remote parts / new http code is a bit more complex as it requires setting up workers in the test framework, which is currently not there, and will probably require refactoring the worker constructor to be usable in tests ( |
(for worker tests, basically we'd need to extract the whole worker thing from the |
I think this is the issue:
I think the correct thing to do here is to just set the proof type in the fsm adapter from |
Superseded by #6280 |
Cherry-picks parts of #5769, and makes them work
Did some testing in a pond devnet with a worker, it seems to work, but needs testing on a real node, and ideally some integration tests